Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/7115#issuecomment-121977404
Looks much better now, except some minor issues. And I didn't check the
logic of `soundex`, it will be great if you can add more unit test for
`soundex`.
Some examples can be found at
https://issues.apache.org/jira/browse/HIVE-9738
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
