Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7451#discussion_r34823962
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -387,27 +370,18 @@ case class Atan2(left: Expression, right: Expression)
protected override def nullSafeEval(input1: Any, input2: Any): Any = {
// With codegen, the values returned by -0.0 and 0.0 are different.
Handled with +0.0
- val result = math.atan2(input1.asInstanceOf[Double] + 0.0,
input2.asInstanceOf[Double] + 0.0)
- if (result.isNaN) null else result
+ math.atan2(input1.asInstanceOf[Double] + 0.0,
input2.asInstanceOf[Double] + 0.0)
--- End diff --
Still need + 0.0 here, `math.atan2` is calling `java.lang.Math.atan2` inside
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
