Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7372#issuecomment-122059360
@cloud-fan I'd prefer not to do this change for two reasons:
1. It was marked private[this] in order to avoid function call (field
access rather than function calls). JVM JIT is pretty good about inlining these
things, but it sometimes doesn't work. Although you could argue in this case it
wouldn't matter since performance sucks elsewhere, but there isn't a lot of
benefits to changing it either.
2. In the long run, we should move towards explicitly initializing all
operators with states, rather than relying on lazy transient val. This is a
direction similar to the expression codegen init stuff you did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
