Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/7431#issuecomment-122150692
  
    
https://issues.apache.org/jira/browse/SPARK-8297?focusedCommentId=14583560&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14583560
    
    has more information. (timeout's for heartbeat is increased due to gc 
issues we see in spark)
    
     I'm guessing there might be situations it doesn't recognize the disconnect 
right away.  Either way I don't think this change hurts anything and it covers 
any weird cases that might happen.   The error message I assume only happens in 
a few cases when you hit the exact race.  Otherwise I would expect one side or 
the other to win. Generally I would expect the spark scheduler recognizing 
disconnect first and cause it to be removed from our list and not even call it. 
 I didn't verify that in the code though, @vanzin  do you happen to know if 
that is true, otherwise I'll check tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to