Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6294#discussion_r34859118
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
@@ -251,7 +296,7 @@ class ReceiverTracker(ssc: StreamingContext,
skipReceiverLaunch: Boolean = false
def stop(graceful: Boolean) {
// Send the stop signal to all the receivers
- stopReceivers()
--- End diff --
Its pretty ugly that ReceiverTracker.stop() calls ReceiverLauncher.stop()
which issues an event in the ReceiverTracker.eventLoop, which calls
ReceiverTracker.stopReceivers(). This should be collapsed. I think the
ReceiverLAuncher.stop can be removed and all that code be moved into
ReceiverTracker.stop(). So ...
1. ReceiverTracker.stop() should issue the `StopAllReceivers` event, and
wait for `running` = false
2. The event loop, on `StopAllReceivers` event, will call the method
stopReceivers() to send the signal (as it is now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
