Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/916#discussion_r13319638
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -402,10 +411,11 @@ abstract class RDD[T: ClassTag](
}
if (num > initialCount && !withReplacement) {
+ // special case not covered in computeFraction
--- End diff --
I don't think it can really prevent overflow. The fraction is chosen as `3
* INT_MAX / count`, which means the expect sample size is `3 * INT_MAX >
INT_MAX`. So `collect()` will throw an exception almost surely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
