Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6981#issuecomment-122176168
@tarekauel for most of the functions you have implemented here, it'd make
sense to put them into static functions somewhere (like DateTimeUtils), and
then just call those functions in both the codegen and the interpreted version.
It makes the code much cleaner and easier to change.
One other thing is when you move them to static functions, please don't use
pattern matching. Use explicit if/else statements even in Scala to improve
performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
