Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7294#issuecomment-122178873
@jkbradley Just thought about how to reduce the review complexity. I think
this PR would be easier to review if you copied the implementation with bins
and kept the 1-1 mapping between files in the first PR. Then the second PR
removed the bins from the implementation and fixes other small issues.
The changes LGTM:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
