Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7458#discussion_r34865653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -537,6 +541,7 @@ class Analyzer(
def containsAggregates(exprs: Seq[Expression]): Boolean = {
exprs.foreach(_.foreach {
case agg: AggregateExpression => return true
--- End diff --
if we are not going to be removing the old aggregate expression for a
while, how about creating a new aggregateexpression that's the shared parent,
and rename existing one aggregateexpression1? i worry we miss places that we
match on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
