Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6872#discussion_r34868017
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
 ---
    @@ -95,6 +94,19 @@ class MathFunctionsSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         checkEvaluation(c(Literal(1.0), Literal.create(null, DoubleType)), 
null, create_row(null))
       }
     
    +  test("conv") {
    --- End diff --
    
    are you saying this is what hive does? i feel it is better to be more 
strict here, e.g. "11abc" just returns null if the base is 10.
    
    However, I don't have a strong preference here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to