Github user tarekauel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6981#discussion_r34870733
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateFunctionsSuite.scala
 ---
    @@ -0,0 +1,259 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions
    +
    +import java.sql.{Timestamp, Date}
    +import java.text.SimpleDateFormat
    +import java.util.{TimeZone, Calendar}
    +
    +import org.apache.spark.SparkFunSuite
    +import org.apache.spark.sql.types.{StringType, TimestampType, DateType}
    +
    +class DateFunctionsSuite extends SparkFunSuite with ExpressionEvalHelper {
    +
    +  val oldDefault = TimeZone.getDefault
    +
    +  val sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
    +  val sdfDate = new SimpleDateFormat("yyyy-MM-dd")
    +  val d = new Date(sdf.parse("2015-04-08 13:10:15").getTime)
    +  val ts = new Timestamp(sdf.parse("2013-11-08 13:10:15").getTime)
    +
    +  test("Day in Year") {
    +    val sdfDay = new SimpleDateFormat("D")
    +    (2002 to 2004).foreach { y =>
    +      (0 to 11).foreach { m =>
    +        (0 to 5).foreach { i =>
    --- End diff --
    
    28, 29, 30, 31, 1.1. It checks until the 1st or 2nd of the next month, 
doesn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to