Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7446#discussion_r34886626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -216,11 +216,9 @@ object ProjectCollapsing extends Rule[LogicalPlan] {
// We only collapse these two Projects if their overlapped
expressions are all
// deterministic.
- val hasNondeterministic = projectList1.flatMap(_.collect {
- case a: Attribute if aliasMap.contains(a) => aliasMap(a).child
- }).exists(_.find(!_.deterministic).isDefined)
+ val noCollapse = projectList1.exists(hasNondeterministic(_,
aliasMap))
--- End diff --
an unrelated but small change, we don't need to go through the whole
project list, can stop once we find nondeterministic expressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
