Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7399#discussion_r34929743
  
    --- Diff: 
core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js ---
    @@ -26,17 +29,31 @@ $(function() {
             // Switch the class of the arrow from open to closed.
             
$(this).find('.expand-additional-metrics-arrow').toggleClass('arrow-open');
             
$(this).find('.expand-additional-metrics-arrow').toggleClass('arrow-closed');
    +
    +        window.localStorage.setItem("expand-additional-metrics", "" + 
status);
         });
     
    +    if (window.localStorage.getItem("expand-additional-metrics") == 
"true") {
    +        // Set it to false so that the click function can revert it
    +        window.localStorage.setItem("expand-additional-metrics", "false");
    +        $("span.expand-additional-metrics").trigger("click");
    +    }
    +
         stripeSummaryTable();
     
         $('input[type="checkbox"]').click(function() {
    -        var column = "table ." + $(this).attr("name");
    +        var name = $(this).attr("name")
    +        var column = "table ." + name;
    --- End diff --
    
    is the space between `table` and `.` here intentional? I notice this is 
also in the old code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to