Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7076#discussion_r34945166
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
 ---
    @@ -45,7 +45,37 @@ object GenerateMutableProjection extends 
CodeGenerator[Seq[Expression], () => Mu
               else
                 ${ctx.setColumn("mutableRow", e.dataType, i, 
evaluationCode.primitive)};
             """
    -    }.mkString("\n")
    +    }
    +    val projectionBlocks = projectionCode.foldLeft(List.empty[String]) {
    --- End diff --
    
    would be great if you can rewrite the code to make it slightly less 
functional here. I'd actually prefer a more imperative version here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to