GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/7488
[SPARK-9167][SQL] call `millisToDays` in `stringToDate`
fix 2 bugs introduced in https://github.com/apache/spark/pull/7353
1. we should call `millisToDays` in `stringToDate`. Before #7353 , we use
`DateTimeUtils.fromJavaDate(Date.valueOf(s.toString))` to cast string to date,
and `fromJavaDate` will call `millisToDays`. Now we use
`DateTimeUtils.stringToDate(s)` but the `millisToDays` is missing in
`stringToDate`.
2. we should not change the default time zone in test cases. The
`threadLocalLocalTimeZone` and `threadLocalTimestampFormat` in `DateTimeUtils`
will only be evaluated once for each thread, so we can't set the time zone back
anymore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark datetime
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/7488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7488
----
commit 21ef293de442a87571a804f4115587f5ead93833
Author: Wenchen Fan <[email protected]>
Date: 2015-07-18T08:01:25Z
fix 2 bugs in datetime
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
