Github user saurfang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7076#discussion_r34953519
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -45,10 +47,41 @@ object GenerateMutableProjection extends
CodeGenerator[Seq[Expression], () => Mu
else
${ctx.setColumn("mutableRow", e.dataType, i,
evaluationCode.primitive)};
"""
- }.mkString("\n")
+ }
+ // collect projections into blocks as function has 64kb codesize limit
in JVM
+ val projectionBlocks = new ArrayBuffer[String]()
+ val blockBuilder = new StringBuilder()
+ for (projection <- projectionCode) {
+ if (blockBuilder.length > 16 * 1000) {
+ projectionBlocks.append(blockBuilder.toString())
+ blockBuilder.clear()
+ }
+ blockBuilder.append(projection)
--- End diff --
The code itself already has a new line before and after. I looked at debug
results and the code look reasonably. I'm happy to add an extra newline to be
safe in case that assumption changes in the future. Just let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
