Github user tarekauel commented on the pull request:
https://github.com/apache/spark/pull/7506#issuecomment-122633436
@rxin Could you do this little fix as well?
https://github.com/apache/spark/pull/7505/files
Why do we switch from day_of_month to dayofmonth? Most SQL implementations
use underscores:
[MySQL](https://dev.mysql.com/doc/refman/5.0/en/func-op-summary-ref.html)
[SAP
HANA](http://help.sap.com/saphelp_hanaplatform/helpdata/en/20/9f228975191014baed94f1b69693ae/content.htm?frameset=/en/20/9ddefe75191014ac249bf78ba2a1e9/frameset.htm¤t_toc=/en/2e/1ef8b4f4554739959886e55d4c127b/plain.htm&node_id=91&show_children=false)
[Oracle](http://docs.oracle.com/cd/B19306_01/server.102/b14200/functions001.htm#i88891)
I would prefer underscores, because they improve the readability, if you
write all SQL stuff in caps, like:
`SELECT name, age, DAY_OF_MONTH(birthday) AS birthday FROM people WHERE age
> 15` compared to `SELECT name, age, DAYOFMONTH(birthday) AS birthday FROM
people WHERE age > 15`
I'm not a Python pro, but I thought that underscores are 'pythonic', aren't
they?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
