Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7478#discussion_r34963298
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/ResolveVirtualColumn.scala
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.expressions
+
+import org.apache.spark.sql.catalyst.analysis._
+import org.apache.spark.sql.catalyst.expressions.{Alias, VirtualColumn}
+import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
+import org.apache.spark.sql.catalyst.rules.Rule
+import org.apache.spark.sql.execution.expressions.SparkPartitionID
+
+/**
+ * Used to resolve virtual column attributes and insert the expression for
them. Add case
+ * statements to this for each additional virtual column
+ */
+private[sql] class ResolveVirtualColumn(resolver: Resolver) extends
Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case lPlan: LogicalPlan => lPlan transformExpressionsUp {
+ case u @ UnresolvedAttribute(nameParts) if nameParts.length == 1 &&
+ resolver(nameParts.head, VirtualColumn.sparkPartitionId) =>
SparkPartitionID
--- End diff --
Still have my previous question. What will happen if we have a query like
`SELECT spark__partition__id from (SELECT a as spark__partition__id FROM table)
tmp`? My main concern is that sometimes we will resolve `spark__partition__id`
as the virtual column, but sometimes we will resolve it as `a`. Can you try
some queries and see if we will have inconsistent behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
