Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7468#discussion_r34967396
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
 ---
    @@ -774,6 +774,114 @@ case class Encode(value: Expression, charset: 
Expression)
     }
     
     /**
    + * Replace all substrings of str that match regexp with rep.
    + *
    + * NOTE: this expression is not THREAD-SAFE, we have to create a instance 
for each thread.
    + */
    +case class RegExpReplace(subject: Expression, regexp: Expression, rep: 
Expression)
    +  extends Expression with ImplicitCastInputTypes with CodegenFallback {
    --- End diff --
    
    @chenghao-intel  the reason I want codegen is not to improve performance of 
this expression itself, but to prevent using fallback because once we fallback, 
all the children expressions will be called without codegen and require a lot 
of boxing.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to