Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7442#discussion_r34973871
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
    @@ -906,12 +908,16 @@ abstract class DStream[T: ClassTag] (
       /**
        * Save each RDD in this DStream as at text file, using string 
representation
        * of elements. The file name at each batch interval is generated based 
on
    -   * `prefix` and `suffix`: "prefix-TIME_IN_MS.suffix".
    +   * `prefix` and `suffix`: "prefix-TIME_IN_MS.suffix". If the 
`CompressionCodec`
    +   * is defined, it will use specific `CompressionCodec` to compress the 
text.
        */
    -  def saveAsTextFiles(prefix: String, suffix: String = ""): Unit = 
ssc.withScope {
    --- End diff --
    
    Yeah I'm surprised because this should be adding a parameter in the 
bytecode, but I could be missing something. Yes, I thought the general idea was 
not to add more methods to `DStream` as in retrospect they were generally not 
adding enough value over operating on `RDD`s.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to