Github user tarekauel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7531#discussion_r35031504
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -77,6 +78,15 @@ public static UTF8String fromString(String str) {
         }
       }
     
    +  /**
    +   * Creates an UTF8String that contains `length` spaces.
    +   */
    +  public static UTF8String blankString(int length) {
    +    byte[] spaces = new byte[length];
    +    Arrays.fill(spaces, (byte) ' ');
    --- End diff --
    
    Char implements UTF-16 
(http://docs.oracle.com/javase/7/docs/api/java/lang/Character.html)
    
    "The char data type (and therefore the value that a Character object 
encapsulates) are based on the original Unicode specification, which defined 
characters as fixed-width 16-bit entities".
    
    Shall I still change it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to