Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7523#discussion_r35059343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullFunctions.scala
---
@@ -25,13 +25,15 @@ import org.apache.spark.sql.types._
/**
- * An expression that is evaluated to the first non-null input.
+ * An expression that is evaluated to the first non-null and non-NaN input.
--- End diff --
This change may be not related to this PR, will it change the behavior of
sum() or avg()?
If yes, I think we have not decide how to do sum() on NaN yet. Can you
leave this change out of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
