Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123118044
Overall it looks good. I'm still a bit concerned about overriding the `glm`
function in base `R`. Let me try a few options to see if there is a way to
onlycapture it when the `data` argument is a `DataFrame`. If that doesn't work,
I think we'll need to use @davies idea of using `ml.glm` or something like
that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
