Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/897#discussion_r13365728
  
    --- Diff: 
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
    @@ -119,16 +119,16 @@ class PairRDDFunctionsSuite extends FunSuite with 
SharedSparkContext {
          * relatively tight error bounds to check correctness of functionality 
rather than checking
          * whether the approximation conforms with the requested bound.
          */
    -    val relativeSD = 0.001
    +    val p = 20
    +    val sp = 0
    +    val relativeSD = 0.01
    --- End diff --
    
    I think it is safe to increase `relativeSD` to `0.005`. Could you put the 
following comment?
    
    When `p = 20`, the relative accuracy is about `0.001`. So with high 
probability, the relative error should be smaller than the threshold `0.005` we 
use here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to