Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7483#issuecomment-123131223 So I checked this and its works pretty well i.e. capturing `glm` only if `DataFrame` is passed to it. However right now the help function doesn't work as it doesn't realize that `glm` is a generic (You can test this with `?glm`). Could you edit `generics.R` to add the following lines at the end ? ``` #' @export setGeneric("glm") ``` That should make the help functions work from what I can see
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org