Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7555#discussion_r35068485
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -598,6 +613,17 @@ private[spark] object JsonProtocol {
SparkListenerLogStart(sparkVersion)
}
+ def executorMetricsUpdateFromJson(json: JValue):
SparkListenerExecutorMetricsUpdate = {
+ val execInfo = (json \ "Executor ID").extract[String]
+ val taskMetrics = (json \"Metrics
Updated").extract[List[JValue]].map(s =>
+ ((s\"Task ID").extract[Long],
+ (s\"Stage ID").extract[Int],
+ (s\"Stage Attempt ID").extract[Int],
+ taskMetricsFromJson(s\"Task Metrics"))
--- End diff --
indentation is weird. Also could you use curly braces for map:
```
val taskMetrics = (json \ "Metrics Updated").extract[List[JValue]].map {
json =>
val taskId = (s \ "Task ID").extract[Long]
val stageId = ...
val stageAttemptId = ...
val metrics = ...
(taskId, stageId, stageAttemptId, metrics)
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
