Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7468#discussion_r35069417
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -464,6 +464,41 @@ class StringExpressionsSuite extends SparkFunSuite
with ExpressionEvalHelper {
checkEvaluation(StringSpace(s1), null, row2)
}
+ test("RegexReplace") {
+ val row1 = create_row("100-200", "(\\d+)", "num")
--- End diff --
@rxin, I've checked the code, only the non-codegen projection will keep a
single expression instance among `checkEvaluation` calls, that means only the
non-codegen version can test the mutable state of the expression.
I will create another PR for updating the unit test framework itself (in
the `ExpressionEvalHelper`), so we can test the mutable status for codegen
expression, but this test will not be changed, can you go ahead to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
