Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7534#discussion_r35071161
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -649,58 +649,65 @@ case class Substring(str: Expression, pos:
Expression, len: Expression)
override def foldable: Boolean = str.foldable && pos.foldable &&
len.foldable
override def nullable: Boolean = str.nullable || pos.nullable ||
len.nullable
- override def dataType: DataType = {
- if (!resolved) {
- throw new UnresolvedException(this, s"Cannot resolve since $children
are not resolved")
- }
- if (str.dataType == BinaryType) str.dataType else StringType
- }
+ override def dataType: DataType = StringType
override def inputTypes: Seq[DataType] = Seq(StringType, IntegerType,
IntegerType)
override def children: Seq[Expression] = str :: pos :: len :: Nil
- @inline
- def slicePos(startPos: Int, sliceLen: Int, length: () => Int): (Int,
Int) = {
+ override def eval(input: InternalRow): Any = {
+ // Information regarding the pos calculation:
--- End diff --
The calculation is not done here, we could remove these comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
