Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/7556#issuecomment-123169782
LGTM in general, the only concern should we add more scaladoc/note, for
those string parameters? Just in case people get confused, if it represents a
string value or column name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
