Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7560#discussion_r35073590
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -648,6 +648,15 @@ class SQLQuerySuite extends QueryTest with
BeforeAndAfterAll with SQLTestUtils {
Row(2, 1, 2, 2, 1))
}
+ test("count of empty table") {
--- End diff --
I added this test to make it easier to catch mistakes in the implementation
of the `groupingExpressions.isEmpty && !iter.hasNext()` case. A wrong
implementation that does not return an empty buffer will quickly be caught by
this test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
