Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7559#discussion_r35078099
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -58,7 +58,11 @@ private[ui] class ExecutorsPage(
val diskUsed = storageStatusList.map(_.diskUsed).sum
val execInfo = for (statusId <- 0 until storageStatusList.size) yield
ExecutorsPage.getExecInfo(listener, statusId)
- val execInfoSorted = execInfo.sortBy(_.id)
+ val execInfoSorted = execInfo.filter(x => {
--- End diff --
What is this doing? this is inefficient (creates regexes every time) and
has strange syntax. Boolean or is not invoked as a method; extra parens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
