Github user MechCoder commented on the pull request:

    https://github.com/apache/spark/pull/7538#issuecomment-123221795
  
    Thanks a lot for your kind reviews :)
    
    > Maybe it might make sense to make a HasSummary trait with the hasSummary 
and setSummary
    
    Yes, indeed. Where should such a trait go? Should we have a ml/summary ? 
Would it better to refactor this in a different PR or this one?
    
    Also It might help to make a `RegressionSummary` or a 
`ClassificationSummary` after this has been done because most of the regression 
metrics and classification metrics are common to different ML algorithms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to