Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7554#issuecomment-123406605
@dusenberrymw Thanks for working on this feature! Please fix the following:
1. Do not introduce methods in Python that are not available on the Scala
side, e.g. `DistributeMatrices`. If we want to add new methods, we should add
them to Scala first and then Python wrappers. If those methods are useful, we
can do that in a follow-up PR.
2. Check code style. For Scala code, we follow
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide. For
Python, we follow PEP8. I saw many long lines in your Python code. Having a
more consistent code style would make code review easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
