Github user kmaehashi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7512#discussion_r35129656
  
    --- Diff: 
repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
    @@ -1008,7 +1008,7 @@ class SparkILoop(
         val jars = SparkILoop.getAddedJars
         val conf = new SparkConf()
           .setMaster(getMaster())
    -      .setAppName("Spark shell")
    +      .setAppName(sys.props.getOrElse("spark.app.name", "Spark shell"))
    --- End diff --
    
    @vanzin If `--name` is not specified on the spark-shell command line, the 
main class name (`org.apache.spark.repl.Main`) is set for `spark.app.name`, so 
`spark.app.name` will not become missing when executed via `spark-shell` 
command line:
    
    
https://github.com/apache/spark/blob/v1.4.1/core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala#L203-L204
    
    The reason why I use `getOrElse` here is just for backward compatibility 
for special use cases (e.g., directly executing Main class of spark-shell 
instead of using spark-shell command line; in this case `spark.app.name` may 
not be set)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to