Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7567#discussion_r35170672
--- Diff: dev/lint-r.R ---
@@ -15,15 +15,18 @@
# limitations under the License.
#
+argv <- commandArgs(TRUE)
+SPARK_ROOT_DIR <- as.character(argv[1])
+
# Installs lintr from Github.
# NOTE: The CRAN's version is too old to adapt to our rules.
if ("lintr" %in% row.names(installed.packages()) == FALSE) {
devtools::install_github("jimhester/lintr")
}
-library(lintr)
-
-argv <- commandArgs(TRUE)
-SPARK_ROOT_DIR <- as.character(argv[1])
+# NOTE: You should install SparkR with `R/install-dev.sh` before running
this script.
+library(lintr)
+library(testthat)
+library(SparkR, lib.loc = file.path(SPARK_ROOT_DIR, "R", "lib"))
--- End diff --
Minor thing -- it would be good for the script to exit if any of these
package loads fail. We can pass in `logical.return=T` to the `library` call to
do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
