Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/7276#issuecomment-123521714
> In the code refactoring, why did you move all the registerReceiver,
deregisterReceiver, etc. into the Endpoint class? That moves around a lot of
code, making it hard to review. Also it makes the overall structure more
complex - some functionality is in the parent ReceiverTracker class and some
are in the EndPoint class, hard to reason about what goes where in the future.
Instead the earlier structure had the goal of all the functionality is in the
ReceiverTracker, and the Endpoint class was just to going to be the event loop
that accesses that functionality. I think its more structured if that is
maintained.
I moved all methods and fields that are only accessed in the endpoint into
the endpoint. I feel it's easy to see they are only accessed in the endpoint.
However, it really makes this PR hard to review. Let me move them back to the
outer class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
