Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7567#discussion_r35173828
--- Diff: dev/lint-r.R ---
@@ -15,15 +15,21 @@
# limitations under the License.
#
+argv <- commandArgs(TRUE)
+SPARK_ROOT_DIR <- as.character(argv[1])
+
# Installs lintr from Github.
# NOTE: The CRAN's version is too old to adapt to our rules.
if ("lintr" %in% row.names(installed.packages()) == FALSE) {
devtools::install_github("jimhester/lintr")
}
-library(lintr)
-argv <- commandArgs(TRUE)
-SPARK_ROOT_DIR <- as.character(argv[1])
+library(lintr)
+library(methods)
+library(testthat)
+if (! library(SparkR, lib.loc = file.path(SPARK_ROOT_DIR, "R", "lib"),
logical.return = TRUE)) {
+ stop("You should install SparkR in a local directory with
`R/instlal-dev.sh`.")
--- End diff --
Minor typo here -- It should be `install-dev.sh`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
