Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7337#issuecomment-123526677
@feynmanliang @zapletal-martin The changes in this PR look good to me
except a few minor comments. As discussed in #6996, let's focus on the public
API to get this merged first.
We can have another PR for code reuse. There would be more discussion,
e.g., having a base class handling arbitrary slicing of the input data and
making `CrossValidator` and `TrainValidationSplit` extend it. I actually think
there will be more lines of code if we implement it that way. It might not be
worth the trade-off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
