Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7154#discussion_r35198763
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -360,24 +369,35 @@ private[sql] class ParquetRelation2(
commonMetadataStatuses =
leaves.filter(_.getPath.getName ==
ParquetFileWriter.PARQUET_COMMON_METADATA_FILE)
- // If we already get the schema, don't need to re-compute it since
the schema merging is
- // time-consuming.
- if (dataSchema == null) {
--- End diff --
This is irrelevant to this PR, but I'd like to point out that this check is
unnecessary now. IIRC, at the time PR #6012 was merged, `ParquetRelation2`
still needed to be serialized to executor side, thus avoiding schema merging on
executor side makes sense. However, after migrating to `HadoopFsRelation`,
`ParquetRelation2` won't be serialized anymore (you may see that
`ParquetRelation2` is no longer a case class and doesn't extend `Serializable`
now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
