Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6644#discussion_r35260195
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -60,7 +60,8 @@ class ExecutorSummary private[spark](
val totalShuffleRead: Long,
val totalShuffleWrite: Long,
val maxMemory: Long,
- val executorLogs: Map[String, String])
+ val executorLogs: Map[String, String],
+ val isRemoved: Boolean)
--- End diff --
the tests are failing b/c this is not binary compatible, but I think this
is OK. In particular, from http://spark.apache.org/docs/latest/monitoring.html
we say:
> New fields may be added to existing endpoints
So we should add a mima exclusion
[here](https://github.com/apache/spark/blob/master/project/MimaExcludes.scala#L37).
The logs of the PR builder tell you exactly what to add:
`ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.status.api.v1.ExecutorSummary.this")`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
