Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6648#discussion_r35286084
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockResolver.scala ---
@@ -39,3 +36,5 @@ trait ShuffleBlockResolver {
def stop(): Unit
}
+
+private[spark] case class ShuffleIdAndAttempt(shuffleId: Int,
stageAttemptId: Int)
--- End diff --
this could be `private[shuffle]` except that its needed in
[`StoragePerfTester`](https://github.com/squito/spark/blob/SPARK_8029_shuffleoutput_per_attempt/tools/src/main/scala/org/apache/spark/tools/StoragePerfTester.scala#L64)
-- I'm not familar enough with it to suggest a potential refactoring. in any
case `private[spark]` isn't too bad.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
