Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7593#discussion_r35343071
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -77,6 +77,7 @@ class Analyzer(
ExtractWindowExpressions ::
GlobalAggregates ::
UnresolvedHavingClauseAttributes ::
+ RemoveEvaluationFromSort ::
--- End diff --
The origin motivation is adding a project to materialize nondeterministic
expressions in ORDER BY to avoid extra evaluation that lead to wrong answer,
see [JIRA](https://issues.apache.org/jira/browse/SPARK-9083). In an offline
discussion we decided to apply this rule for all still-need-evaluate
expressions. But now I think it maybe overkill. @rxin What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
