Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7605#discussion_r35349035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -36,7 +36,7 @@ case class PrecisionInfo(precision: Int, scale: Int) {
/**
* :: DeveloperApi ::
* The data type representing `java.math.BigDecimal` values.
- * A Decimal that might have fixed precision and scale, or unlimited
values for these.
+ * A Decimal that must have fixed precision and scale.
*
* Please use [[DataTypes.createDecimalType()]] to create a specific
instance.
*/
--- End diff --
would it make more sense to make precision and scale the two parameters of
DecimalType, rather than an optional PrecisionInfo?
To keep binary compatibility, we can still create a function called
precisionInfo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
