Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/7424#discussion_r35352704
--- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
@@ -141,6 +141,10 @@ class NewHadoopRDD[K, V](
override def hasNext: Boolean = {
if (!finished && !havePair) {
finished = !reader.nextKeyValue
+ if (finished) {
+ // Close reader and release it
--- End diff --
Could you change this comment (and the one in SqlNewHadoopRdd) to say
something like "Close and release the reader here; close() will also be called
when the task completes, but for tasks that read from many files, it helps to
release the resources early"? I'm just worried this could be removed later on
if someone things it's redundant with the close() in task completion listener.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
