Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7605#discussion_r35353429
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -88,6 +88,16 @@ abstract class BinaryArithmetic extends BinaryOperator {
override def dataType: DataType = left.dataType
+ // Whether the dataType is promoted or not, we should only promote
DecimalType once
+ var decimalPromoted: Boolean = false
--- End diff --
can you explain why this is needed? In addition, I'm not sure about adding
a non-execution mutable state here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
