Github user yu-iskw commented on a diff in the pull request:
https://github.com/apache/spark/pull/7584#discussion_r35392063
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1384,7 +1384,7 @@ setMethod("saveAsTable",
"org.apache.spark.sql.parquet")
}
allModes <- c("append", "overwrite", "error", "ignore")
- if (!(mode %in% allModes)) {
+ if (! (mode %in% allModes)) {
--- End diff --
I'm with @sun-rui. I prefer the following style:
```!<var>, !<function call> and !(<expression>)```
Unfortunately, we can't currently customize the linter about a space before
left parenthesis to do that. So I think we should add a new rule into lintr in
itself. Otherwise, should we turn off the linter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
