Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7279#discussion_r35393044
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/LocalCheckpointRDD.scala 
---
    @@ -0,0 +1,67 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.rdd
    +
    +import scala.reflect.ClassTag
    +
    +import org.apache.spark.{Partition, SparkContext, SparkEnv, 
SparkException, TaskContext}
    +import org.apache.spark.storage.RDDBlockId
    +
    +/**
    + * A dummy CheckpointRDD that exists to provide informative error messages 
during failures.
    + *
    + * This is simply a placeholder because the original checkpointed RDD is 
expected to be
    + * fully cached. Only if an executor fails or if the user explicitly 
unpersists the original
    + * RDD will Spark ever attempt to compute this CheckpointRDD. When this 
happens, however,
    + * we must provide an informative error message.
    + *
    + * @param sc the active SparkContext
    + * @param rddId the ID of the checkpointed RDD
    + * @param partitionIndices the partition indices of the checkpointed RDD
    + */
    +private[spark] class LocalCheckpointRDD[T: ClassTag](
    +    @transient sc: SparkContext,
    +    rddId: Int,
    +    partitionIndices: Array[Int])
    +  extends CheckpointRDD[T](sc) {
    +
    +  def this(rdd: RDD[T]) {
    +    this(rdd.context, rdd.id, rdd.partitions.map(_.index))
    +  }
    +
    +  protected override def getPartitions: Array[Partition] = {
    +    partitionIndices.map { i => new CheckpointRDDPartition(i) }
    +  }
    +
    +  /**
    +   * Throw an exception indicating that the relevant block is not found.
    +   *
    +   * This should only be called if the original RDD is explicitly 
unpersisted or if an
    +   * executor is lost. Under normal circumstances, however, the original 
RDD (our child)
    +   * is expected to be fully cached and so all partitions should already 
be computed and
    +   * available in the block storage.
    +   */
    +  override def compute(partition: Partition, context: TaskContext): 
Iterator[T] = {
    +    throw new SparkException(
    +      s"Checkpoint block ${RDDBlockId(rddId, partition.index)} not found! 
Either the executor " +
    +      s"that originally checkpointed this block is no longer alive, or the 
original RDD is " +
    --- End diff --
    
    The user does not know about any "block", so they will get confused. Better 
to say something like "...the original data of locally checkpointed RDD is 
lost...you have to recompute the original RDD manually ..."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to