Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7520#discussion_r35396110
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala ---
@@ -86,19 +86,10 @@ private[orc] class OrcOutputWriter(
TypeInfoUtils.getTypeInfoFromTypeString(
HiveMetastoreTypes.toMetastoreType(dataSchema))
- TypeInfoUtils
- .getStandardJavaObjectInspectorFromTypeInfo(typeInfo)
- .asInstanceOf[StructObjectInspector]
+ OrcStruct.createObjectInspector(typeInfo.asInstanceOf[StructTypeInfo])
+ .asInstanceOf[SettableStructObjectInspector]
--- End diff --
Is it safe to cast to SettableStructObjectInspector, because the function
signature is
ObjectInspector createObjectInspector. Although the current
implementation may all return SettableStructObjectInspector.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
