Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6394#discussion_r35399233
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
    @@ -28,7 +28,10 @@ private[spark] trait ExecutorAllocationClient {
        * This can result in canceling pending requests or filing additional 
requests.
        * @return whether the request is acknowledged by the cluster manager.
        */
    -  private[spark] def requestTotalExecutors(numExecutors: Int): Boolean
    +  private[spark] def requestTotalExecutors(
    +      numExecutors: Int,
    --- End diff --
    
    Mind adding the above text to the documentation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to