Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7122#discussion_r35415063
  
    --- Diff: 
core/src/test/scala/org/apache/spark/serializer/JavaSerializerSuite.scala ---
    @@ -25,4 +25,18 @@ class JavaSerializerSuite extends SparkFunSuite {
         val instance = serializer.newInstance()
         instance.deserialize[JavaSerializer](instance.serialize(serializer))
       }
    +
    +  test("Deserialize object containing a primitive Class as attribute") {
    +    val serializer = new JavaSerializer(new SparkConf())
    +    val instance = serializer.newInstance()
    +    instance.deserialize[JavaSerializer](instance.serialize(new 
ContainsPrimitiveClass()))
    +  }
    --- End diff --
    
    I'd like to have a test that we still get the original ClassNotFound in 
other cases, but I'm not sure how to do that ... perhaps you could write a test 
where you serialize with a special classloader which loads an extra class, and 
then deserialize with a different classloader?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to